Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update error string for --file-locks test #12367

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

rst0git
Copy link
Contributor

@rst0git rst0git commented Nov 19, 2021

Add fileLocks api option and replace the update the substring test to match the end of the error message.

Closes: #12366

Use a substring matching the end of the error message.

Closes: containers#12366

Signed-off-by: Radostin Stoyanov <[email protected]>
@flouthoc
Copy link
Collaborator

LGTM, I think this is needed urgently cause some unrelated checkpoint tests are failing across CI in other PR

@flouthoc
Copy link
Collaborator

@rst0git Is this also related to the flakes seen here #12364

@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2021

/lgtm
/approve
/hold
Thanks @rst0git

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2021
@rst0git
Copy link
Contributor Author

rst0git commented Nov 19, 2021

@rst0git Is this also related to the flakes seen here #12364

Yes, it looks like the same problem.

@flouthoc
Copy link
Collaborator

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@flouthoc
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan, rst0git

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 671e5ee into containers:main Nov 19, 2021
@rst0git rst0git deleted the file-locks-1 branch November 19, 2021 16:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[remote] checkpoint --file-lock test: new flake
5 participants