filter: use filepath.Match to maintain consistency with other pattern matching in podman
#12364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Nov 19, 2021
flouthoc
force-pushed
the
fix-filter-pattern
branch
from
9f4d017 to
f9a4723
Compare
|
@vrothberg Sorry i forgot to add context for change in PR description. So in previous PR we had concerns about using More context here: #12295 (comment) |
flouthoc
force-pushed
the
fix-filter-pattern
branch
from
f9a4723 to
8471104
Compare
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
matching in podman Following commit ensures that we maintain consistency with how pattern matching is being carried out everywhere else in podman. Switch from `regexp` to `filepath.Match` For example https://github.com/containers/common/blob/main/libimage/filters.go#L162 [NO NEW TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
fix-filter-pattern
branch
from
8471104 to
6011149
Compare
|
Just a rebase after #12367 |
|
/lgtm |
openshift-ci
bot
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following commit ensures that we maintain consistency with how pattern
matching is being carried out everywhere else in podman.
Switch from
regexptofilepath.MatchFor example https://github.com/containers/common/blob/main/libimage/filters.go#L162
[NO TESTS NEEDED]
Tests were already added in #12295