Change error message for compatibility with docker

[mscherer]

Fixes #12315

Signed-off-by: Michael Scherer [email protected]

[ NO NEW TESTS NEEDED ]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[Luap99]

I do not think this is the right approach. utils.Error() is used for all error in the API. We should not change this. This will also impact the libpod api. To fix this only the compat api has to return the correct error struct. I assume this will affect all docker compat endpoints not just this one.

[mscherer]

Indeed. So I tested that PR, and it seems to fix my initial problem. Not sure if that fix all instance of the same issue.

[mscherer]

(when I say "test that PR", I mean, the latest iteration, where the error is wrapped, and only for the compat API, sorry if that's not clear)

[rhatdan]

@Luap99 @mheon @jwhonce utils.Error currently takes in an APIMessage and then does nothing with it. Should we change the API to drop this or should we wrap the error message with the API Message?

[jwhonce]

@rhatdan The initial implementation had Cause as the error.Error() text while Message was a human readable message for presentation. That got lost over time. Now we have Cause == error.Cause().Error() and Message == error.Error(). I am okay with removing the parameter apiMessage as it is meaningless and unused at this time.

[rhatdan]

@jwhonce Are you ok with merging this PR?

[jwhonce]

/merge

[rhatdan]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mscherer, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment