Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems compat to see 'No such image' when creating container #12317

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 16, 2021

[ NO NEW TESTS NEEDED ]
Signed-off-by: Daniel J Walsh [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[ NO NEW TESTS NEEDED ]
Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Nov 16, 2021

See if this fixes: #12315

@rhatdan
Copy link
Member Author

rhatdan commented Nov 16, 2021

@mscherer could you try this out and see if this fixes the problem.
@mheon @jwhonce The Utils.Error code seems like it could use some work.

@rhatdan
Copy link
Member Author

rhatdan commented Nov 16, 2021

It looks like the Docker clients are expecting "No such %s" in their error messages, but we tend to return

"%s not found", Should we generalize this for Docker compatibility.

@mscherer
Copy link
Contributor

So I tired. It doesn't work. however, if the patch is change to modify the "Message" key, as in #12315 (comment) , it work

(then I hit another issue where docker normalize image name and I have no idea on how to fix that one without lowering security)

@mscherer
Copy link
Contributor

See #12318

@Luap99
Copy link
Member

Luap99 commented Nov 16, 2021

Lets close this in favour of #12318

@Luap99 Luap99 closed this Nov 16, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants