Fix flake in upgrade tests

[Luap99]

What this PR does / why we need it:

The cni plugins need access to /run/cni and the dnsname plugin needs
access to /run/containers.

The race condition was basically that a podman stop could either do the
cleanup itself or the spawned cleanup process would do the cleanup if it
was fast enough. The podman stop is executed on the host while the
podman cleanup process is executed in the "parent container". The parent
container contains older plugins than on the host. The dnsname plugin
before version 1.3 could error and this would prevent CNI from
doing a proper cleanup. The plugin errors because it could not find its
files in /run/containers. On my system the test always failed because
the cleanup process was always faster than the stop process. However in
the CI VMs the stop process was usually faster and so it failed only
sometimes.

How to verify it

Which issue(s) this PR fixes:

Fixes #11558

Special notes for your reviewer:

[rhatdan]

LGTM

[mheon]

/lgtm
/approve
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

LGTM but tests aren't happy:

Error: statfs /run/cni: no such file or directory

(And I see that someone just pressed Re-run on them all, but I don't think this is a flake)

[edsantiago]

Root cause: on a fresh VM such as the ones used in CI, /run/cni does not exist. Best place to add it is probably somewhere around here:

podman/test/upgrade/test-upgrade.bats

Lines 126 to 127 in fa8184c

	# Not entirely a NOP! This is just so we get /run/crun created on a CI VM
	$PODMAN run --rm $OLD_PODMAN true

One could do a simple mkdir /run/cni but I would prefer to have it created the proper way. Unfortunately, I can't seem to figure out a magic podman command that will do so. (I tried various forms of network create and run -p 8080:8080). I'm sure that's a no-brainer for you so I leave it in your hands.

[Luap99]

@edsantiago Should be fixed now: --mac-address ... is needed to create /run/cni and a custom network is needed to create /run/containers

[edsantiago]

/lgtm