Merge pull request #12240 from umohnani8/table

Print headers for system connection ls
containers · Nov 10, 2021 · fa8184c · fa8184c
2 parents 546ad0e + a55fdbb
commit fa8184c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/cmd/podman/system/connection/list.go b/cmd/podman/system/connection/list.go
@@ -53,10 +53,6 @@ func list(cmd *cobra.Command, _ []string) error {
 		return err
 	}
 
-	if len(cfg.Engine.ServiceDestinations) == 0 {
-		return nil
-	}
-
 	hdrs := []map[string]string{{
 		"Identity": "Identity",
 		"Name":     "Name",

diff --git a/test/e2e/system_connection_test.go b/test/e2e/system_connection_test.go
@@ -236,7 +236,7 @@ var _ = Describe("podman system connection", func() {
 			session := podmanTest.Podman(cmd)
 			session.WaitWithDefaultTimeout()
 			Expect(session).Should(Exit(0))
-			Expect(session.Out.Contents()).Should(BeEmpty())
+			Expect(len(session.OutputToStringArray())).Should(Equal(1))
 			Expect(session.Err.Contents()).Should(BeEmpty())
 		})
 	})

diff --git a/test/system/272-system-connection.bats b/test/system/272-system-connection.bats
@@ -50,7 +50,8 @@ function _run_podman_remote() {
 # Very basic test, does not actually connect at any time
 @test "podman system connection - basic add / ls / remove" {
     run_podman system connection ls
-    is "$output" "" "system connection ls: no connections"
+    is "$output" "Name        URI         Identity    Default" \
+       "system connection ls: no connections"
 
     c1="c1_$(random_string 15)"
     c2="c2_$(random_string 15)"