Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Update to Ubuntu 21.10 + Disable F33 #12256

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Nov 10, 2021

What this PR does / why we need it:

Update the Ubuntu CI environment from 21.04 -> 21.10

How to verify it

The Ubuntu-based CI tests will all pass

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does NOT update the Fedora images, this is being done separately in #11795

Ref: containers/automation_images#100

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@edsantiago
Copy link
Member

Oooh! Will this include a new crun that includes containers/crun#758 ? My PR #11957 has been stalled waiting for that!

@cevich
Copy link
Member Author

cevich commented Nov 10, 2021

Oooh! Will this include a new crun

Possibly, it's using whatever is in Lokesh's OBS Kubik testing-repo. Actually, I can poke at the Ubuntu container image and tell you right now...

@cevich
Copy link
Member Author

cevich commented Nov 10, 2021

...here's what's in the containers (should match the VMs)-

Ubuntu 21.10: crun-100:1.2-2
Fedora 34: crun-1.3-1.fc34 (updates-testing)
Fedora 33: crun-1.0-1.fc33 (updates)

I'm not sure what version you're looking for where, but if it's Ubuntu 21.10, @lsm5 knows which strings to pull for it to get updated (assuming that's needed)

@edsantiago
Copy link
Member

If I read the git log correctly, the fix I need is in crun 1.3. Looks like I have a ways to wait still. Oh well, thank you!

@cevich
Copy link
Member Author

cevich commented Nov 10, 2021

If I read the git log correctly, the fix I need is in crun 1.3

Maybe not too much longer. With this PR and the F35 one, we can get what you need.

@lsm5 is it possible for you to bump crun in U21.10 kubik testing to 1.3 or are we using the distro-packaged one?

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

Crun 1.3 building now, Ref: https://build.opensuse.org/package/show/devel:kubic:libcontainers:testing/crun

@edsantiago
Copy link
Member

Weird. podman-remote f33 root failures are all consistently of the form "timed out waiting for podman run -dt with-network-ports".

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

Hmmm, that's new.

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

Yeah, I don't get it, something may have changed in the images since I rebuilt them this morning. In any case, F33 is officially dead, so with this PR + 11795 we should be okay. In fact today, I've been thinking about just combining the two to make life easier.

With F35 released, F33 is officially dead.  Move it out of the way
temporarily until F35 VM images are ready.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich changed the title WIP: Cirrus: Update to Ubuntu 21.10 Cirrus: Update to Ubuntu 21.10 + Disable F33 Nov 11, 2021
@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

Okay there, let's do it this way and I'll turn back on "prior-fedora" when it represents F34.

@cevich cevich marked this pull request as ready for review November 11, 2021 19:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2021
@edsantiago
Copy link
Member

FWIW I'm not convinced that this is an f33 problem. I ran my PR #11957 using these images, and f33 passed just fine. I don't know what to do with that information, though.

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

my PR #11957 using these images, and f33 passed just fine

Hmmm...maybe that damn random-isn't-random thing or some other flake is happening then. Okay, good to know it seems to be a flake of some sort.

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

To be clear: My motivation is to get this PR in ASAP since it seems to have low-resistance test-failure wise. Also there are a number of other PRs waiting on an image-update (in general) in order to pick up things like the new golang 1.17 and updated catatonit.

@edsantiago
Copy link
Member

I'm always eager to merge PRs like this, where the VMs are updated, because they are representative of the real world. My concern here is not "let's skip this PR", but rather "something has broken in f33, and we need to be prepared to troubleshoot it".

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

and we need to be prepared to troubleshoot it.

Only until this PR is merged since officially F33 isn't supported anymore...Of course I'm assuming this problem hasn't and won't shown up in F34+. And to TBH, I'm just REALLY exhausted with working on VM image update PRs and want to move on to other things 😜

@edsantiago
Copy link
Member

OMG so many flakes. Restarted.

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2021

LGTM

@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

OMG so many flakes. Restarted.

Thanks. Nothing stood out at me in the journal, and those tests passed previously, so 🤷‍♂️ must really be flakes 😞

Nov 11 19:58:50 cirrus-task-5997224665546752 conmon[219481]: Load average: 4.70 4.50 4.00 8/1076 1

Oof...Well...at least we're getting our money's worth out of those two vCPUs 😁

@edsantiago
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@cevich
Copy link
Member Author

cevich commented Nov 11, 2021

Okay, seems "safe" to merge this (there are some flakes). I'm just too timid to actually press the button. Who wants a 🍪 Who wants a 🍪 ?

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2021

/approve
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 92da868 into containers:main Nov 11, 2021
@cevich cevich deleted the update_to_U2110 branch April 18, 2023 14:55
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants