cgroup: fix race condition when enabling controllers #758
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcrun_container_restore_linux_criu already sets the external descriptors. commit 979f6f0 introduced the regression. Signed-off-by: Giuseppe Scrivano <[email protected]>
flouthoc
reviewed
Oct 19, 2021
It seems the kernel can return EBUSY when a process was moved to a sub-cgroup and the controllers are enabled in its parent cgroup. On EBUSY retry a few times until a controller could be enabled. Reported: containers/podman#9752 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
LGTM |
rhatdan
reviewed
Oct 19, 2021
| { | ||
| if (crun_error_get_errno (err) == EBUSY) | ||
| repeat = true; | ||
| crun_error_release (err); |
There was a problem hiding this comment.
Should there be any sleep or something here?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the kernel can return EBUSY when a process was moved to a sub-cgroup and the controllers are enabled in its parent cgroup.
On EBUSY retry a few times until a controller could be enabled.
Reported: containers/podman#9752
Signed-off-by: Giuseppe Scrivano [email protected]