pod create: read infra image from containers.conf

[vrothberg]

Fix a bug where pods would be created with the hard-coded default infra
image instead of the custom one from containers.conf. Add a simple
regression test.

Fixes: #12245
Signed-off-by: Valentin Rothberg [email protected]

[vrothberg]

@mheon, possibly a candidate for 3.4.

[vrothberg]

Closing in favor of #12249.

[giuseppe]

LGTM

[vrothberg]

had to repush to restart the CI jobs

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Have you tested this with podman play kube? I'm seeing a weird issue in the tests, wherein the 700-play.bats test pulls in both podman-pause and k8s.io/pause. Will investigate further but wanted to mention it.

[vrothberg]

Have you tested this with podman play kube? I'm seeing a weird issue in the tests, wherein the 700-play.bats test pulls in both podman-pause and k8s.io/pause. Will investigate further but wanted to mention it.

Thanks for catching it. I will have a look. Probably the same/similar issue with using the hard-coded default instead of what containers.conf wants.

[vrothberg]

@containers/podman-maintainers PTAL

[mheon]

/lgtm