create: do not hardcode imageName to DefaultInfraImage #12249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the setting in the containers.conf file is not honored. Closes: containers#12245 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Nov 10, 2021
| defer os.Unsetenv("CONTAINERS_CONF") | ||
|
|
||
| if IsRemote() { | ||
| podmanTest.RestartRemoteService() |
There was a problem hiding this comment.
Why? Shouldn't this come from the client?
There was a problem hiding this comment.
since your PR deals with this better, let's close mine in favor of yours
vrothberg
reviewed
Nov 10, 2021
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
create: do not hardcode imageName to DefaultInfraImage otherwise the setting in the containers.conf file is not honored.
How to verify it
Which issue(s) this PR fixes:
Fixes #12245
Special notes for your reviewer: