Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/onsi/gomega from 1.16.0 to 1.17.0 #12215

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 8, 2021

Bumps github.com/onsi/gomega from 1.16.0 to 1.17.0.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.17.0

1.17.0

Features

  • Add HaveField matcher [3a26311]
  • add Error() assertions on the final error value of multi-return values (#480) [2f96943]
  • separate out offsets and timeouts (#478) [18a4723]
  • fix transformation error reporting (#479) [e001fab]
  • allow transform functions to report errors (#472) [bf93408]

Fixes

Stop using deprecated ioutil package (#467) [07f405d]

Changelog

Sourced from github.com/onsi/gomega's changelog.

1.17.0

Features

  • Add HaveField matcher [3a26311]
  • add Error() assertions on the final error value of multi-return values (#480) [2f96943]
  • separate out offsets and timeouts (#478) [18a4723]
  • fix transformation error reporting (#479) [e001fab]
  • allow transform functions to report errors (#472) [bf93408]

Fixes

Stop using deprecated ioutil package (#467) [07f405d]

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.16.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
To complete the pull request process, please assign vrothberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @vrothberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Nov 8, 2021

This update requires Go 1.16, which doesn't seem to be available on F33 and Ubuntu 21.04.

@cevich I imagine we're dropping F33 soon - what's the story with 21.04?

@cevich
Copy link
Member

cevich commented Nov 8, 2021

Correct, #11795 will drop F33 and I've got another VM image build ready to go that bumps Ubuntu up to 21.10 Though IIRC, @baude has some magic set to use another golang in our Ubuntu. I'll take a look at that and make sure it's also on 1.16+

@vrothberg
Copy link
Member

I hit the issue in #12239 as well (c/common already bumped it) and now force 1.16.0 over there (see the replace line in go.mod).

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2021

Looks like github.com/onsi/gomega is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 9, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/gomega-1.17.0 branch November 9, 2021 15:58
@vrothberg
Copy link
Member

Looks like github.com/onsi/gomega is up-to-date now, so this is no longer needed.

Still need a newer Go so we can remove the replace line in go.mod

@cevich
Copy link
Member

cevich commented Nov 9, 2021

Okay, I've got golang 1.17 wired up for the next set of Ubuntu images, and we get 1.16 by default in F35 (and 34 IIRC).

@cevich
Copy link
Member

cevich commented Nov 9, 2021

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants