-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code from libpod #11628
Remove unused code from libpod #11628
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The libpod package should only compile on linux. The remote client should never try to import this package. Since these files do not add any value we should remove them, this prevents people from accidentally importing this package because it would fail to compile on windows/macos. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]>
3970f76
to
c692f7a
Compare
LGTM should help us from accidently sucking it into the podman-remote code base. |
LGTM! |
Been seeing this one failing on a bunch of PRs. @edsantiago Potential new flake? |
Yes definitely a new flake, the actual problem is this warning message |
LGTM |
@edsantiago we have a new flake caused by the podman unshare exit code test. [+1604s] : time="2021-09-17T16:07:41-05:00" level=warning msg="Failed to add pause process to systemd sandbox cgroup: mkdir /sys/fs/cgroup/pids/user.slice/user-9141.slice/[email protected]/user.slice: permission denied" For some reason once in a while the cgroups are failing to be checked. |
/lgtm |
/hold cancel |
opened a PR: #11648 |
The libpod package should only compile on linux. The remote client
should never try to import this package.
Since these files do not add any value we should remove them, this
prevents people from accidentally importing this package because it would
fail to compile on windows/macos.