Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from libpod #11628

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 17, 2021

The libpod package should only compile on linux. The remote client
should never try to import this package.

Since these files do not add any value we should remove them, this
prevents people from accidentally importing this package because it would
fail to compile on windows/macos.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
The libpod package should only compile on linux. The remote client
should never try to import this package.

Since these files do not add any value we should remove them, this
prevents people from accidentally importing this package because it would
fail to compile on windows/macos.

[NO TESTS NEEDED]

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2021

LGTM should help us from accidently sucking it into the podman-remote code base.

@mheon
Copy link
Member

mheon commented Sep 17, 2021

LGTM!

@mheon
Copy link
Member

mheon commented Sep 17, 2021

[+1771s] [Fail] Podman unshare [It] podman unshare exit codes

Been seeing this one failing on a bunch of PRs. @edsantiago Potential new flake?

@Luap99
Copy link
Member Author

Luap99 commented Sep 17, 2021

[+1771s] [Fail] Podman unshare [It] podman unshare exit codes

Been seeing this one failing on a bunch of PRs. @edsantiago Potential new flake?

Yes definitely a new flake, the actual problem is this warning message time="2021-09-17T09:29:20-05:00" level=warning msg="Failed to add pause process to systemd sandbox cgroup: mkdir /sys/fs/cgroup/devices/user.slice/user-2604.slice: permission denied" added in #11606
@giuseppe PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM
once the tests are hip

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2021

@edsantiago we have a new flake caused by the podman unshare exit code test.

[+1604s] : time="2021-09-17T16:07:41-05:00" level=warning msg="Failed to add pause process to systemd sandbox cgroup: mkdir /sys/fs/cgroup/pids/user.slice/user-9141.slice/[email protected]/user.slice: permission denied"

For some reason once in a while the cgroups are failing to be checked.
@giuseppe Thoughts.

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2021

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit a9e95eb into containers:main Sep 18, 2021
@Luap99 Luap99 deleted the remove-unsued-code branch September 19, 2021 13:38
@giuseppe
Copy link
Member

[+1604s] : time="2021-09-17T16:07:41-05:00" level=warning msg="Failed to add pause process to systemd sandbox cgroup: mkdir /sys/fs/cgroup/pids/user.slice/user-9141.slice/[email protected]/user.slice: permission denied"

For some reason once in a while the cgroups are failing to be checked.
@giuseppe Thoughts.

opened a PR: #11648

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants