runtime: move pause process to scope #11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
giuseppe
force-pushed
the
always-move-pause-process-to-scope
branch
2 times, most recently
from
b460c9c to
a39efca
Compare
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
flouthoc
reviewed
Sep 16, 2021
we already know the path to the pause PID file, no need to calculate it again. Signed-off-by: Giuseppe Scrivano <[email protected]>
when running on a systemd with systemd, always try to move the pause process to its own scope. Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
make sure the pause process is moved to its own scope as well as what we do when we join an existing user+mount namespace. Closes: containers#11560 [NO TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
always-move-pause-process-to-scope
branch
from
a39efca to
a2c8b5d
Compare
|
LGTM |
|
@flouthoc could you add a /lgtm? |
|
/lgtm |
|
@Luap99 Could you do a |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the pause process is moved to its own scope as well as what we do when we join an existing user+mount namespace.
Closes: #11560
[NO TESTS NEEDED]
Signed-off-by: Giuseppe Scrivano [email protected]