Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman upgrade tests for networking #11485

Merged
merged 1 commit into from
Sep 9, 2021
Merged

podman upgrade tests for networking #11485

merged 1 commit into from
Sep 9, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 8, 2021

Test basic networking functionality in the upgrade tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
Luap99
Luap99 commented Sep 8, 2021
View reviewed changes
test/upgrade/test-upgrade.bats Outdated Show resolved Hide resolved
@Luap99 Luap99 force-pushed the network-upgrade-test branch from 0952740 to c85dfa1 Compare September 8, 2021 18:52
@Luap99 Luap99 requested a review from edsantiago September 8, 2021 18:53
edsantiago
edsantiago reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work, thank you! A few suggestions, no showstoppers.

test/upgrade/helpers.bash Outdated Show resolved Hide resolved
test/upgrade/helpers.bash Outdated Show resolved Hide resolved
test/upgrade/test-upgrade.bats Outdated Show resolved Hide resolved
test/upgrade/test-upgrade.bats Outdated Show resolved Hide resolved
test/upgrade/test-upgrade.bats Outdated Show resolved Hide resolved
@Luap99
podman upgrade tests for networking
4d9dcab 
Test basic networking functionality in the upgrade tests.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 force-pushed the network-upgrade-test branch from c85dfa1 to 4d9dcab Compare September 9, 2021 08:26
@Luap99
Copy link
Member Author

Luap99 commented Sep 9, 2021

@edsantiago Comments are fixed. I also made a small change because network connect should happen before restart.

@edsantiago
Copy link
Member

/lgtm
/hold

Thanks again!

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 32eaf34 into containers:main Sep 9, 2021
@Luap99 Luap99 deleted the network-upgrade-test branch September 9, 2021 11:47
@edsantiago edsantiago mentioned this pull request Sep 9, 2021
Closed
@Luap99 Luap99 mentioned this pull request Sep 9, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago left review comments

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luap99 @edsantiago @openshift-merge-robot