Wire network interface into libpod

[Luap99]

Wire network interface into libpod

Make use of the new network interface in libpod.

This commit contains several breaking changes:

• podman network create only outputs the new network name and not file
  path.
• podman network ls shows the network driver instead of the cni version
  and plugins.
• podman network inspect outputs the new network struct and not the cni
  conflist.
• The bindings and libpod api endpoints have been changed to use the new
  network structure.

The container network status is stored in a new field in the state. The
status should be received with the new c.getNetworkStatus. This will
migrate the old status to the new format. Therefore old containers should
continue to work correctly in all cases even when network connect/
disconnect is used.

New features:

• podman network reload keeps the ip and mac for more than one network.
• podman container restore keeps the ip and mac for more than one
  network.
• The network create compat endpoint can now use more than one ipam
  config.

The man pages and the swagger doc are updated to reflect the latest
changes.

Drop OCICNI dependency

We do not use the ocicni code anymore so let's get rid of it. Only the
port struct is used but we can copy this into libpod network types so
we can debloat the binary.

The next step is to remove the OCICNI port mapping form the container
config and use the better PortMapping struct everywhere.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@edsantiago Is there something like skip_if_not_fedora for the system tests? One new test needs containernetworking-plugins 1.0 or newer. This is only available in fedora at the moment. I would like to do a version check but /usr/libexec/cni/bridge just prints version unknown. So I guess I have to use skip_if_ubuntu/skip_if_not_fedora until the package is updated. Or do you know a better way?

[edsantiago]

There are no such skip helpers, because I consider such usage (checking for OS/distro) improper: the correct way is to test for functionality. ISTM that you actually have that?

    cni=/usr/libexec/cni/bridge       ! FIXME: there should be a better way to find this, but `podman info` does not help
    test -x $cni || skip "CNI executable $cni not installed"
    run $cni --version
    cni_version=$(expr "$output" : ".* plugin version \(.*\)")
    [[ $cni_version -ge 1.0 ]] || skip "Test requires CNI >= 1.0 (found: $cni_version)"

Using [[ will treat unknown as < 1.0 without emitting a warning. Using test will also work, but with "integer expression expected" warning.

[Luap99]

/usr/libexec/cni/bridge always prints unknown even for 1.0 so this does not work.

[Luap99]

Also it looks like the path is /usr/lib/cni/bridge on debian/ubuntu

[edsantiago]

/usr/libexec/cni/bridge always prints unknown even for 1.0 so this does not work.

Well, that's obviously a bug and it must be fixed; but equally obviously, it can't get fixed in time for your PR.

What is the shortest, simplest way to behavior-check and identify good-new-cni vs old-bad-cni? Is there a podman network foo bar that will exit error with old-cni and success on new-cni? If so, you could add such a test to setup() in the system test file that requires it. (If multiple test files, then it's better to add require_cni_with_FEATURENAME to helpers.bash).

[Luap99]

For now this is the only test which requires the new functionality so it doesn't make sense to use the same test to check if the test should be skipped so I will remove the parts which require v1.0. In future PRs I will add functionality to test this in a reasonable way.

[TomSweeneyRedHat]

Manpage changes LGTM.
I did a very high-level skim review and it LGTM and we've happy green test buttons.

[Luap99]

/hold cancel
we have a 3.4 branch so this can merge

[Luap99]

@mheon @baude PTAL

[mheon]

You have a vendor conflict. LGTM once that's resolved.

[rhatdan]

/lgtm
/hold

[rhatdan]

/hold cancel