You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Podman is going to abstract CNI from libpod (see containers/podman#11232).
When the work is done libpod will no longer use the CNI result as network status. I am currently wiring the new interface into libpod and noticed that the CNI result is dumped into the checkpoint dir and that this library is using the result on restore to the set the ip and mac address. In my opinion this library should not have to know anything about the network status used in podman. I think it would make more sense to handle setting the correct ip and mac entirely in libpod and not here.
The text was updated successfully, but these errors were encountered:
Somewhat, I don't how many consumers this lib has but if GetIPFromNetworkStatus and GetMACFromNetworkStatus are only used by Podman I think it is safe to remove CNI completely. If the functions are also used elsewhere then this has to stay obviously.
Anyway the Podman network status will be changed in containers/podman#11322. When the PR is merged this lib will no longer be able to unmarshal this into a CNI result.
Podman is going to abstract CNI from libpod (see containers/podman#11232).
When the work is done libpod will no longer use the CNI result as network status. I am currently wiring the new interface into libpod and noticed that the CNI result is dumped into the checkpoint dir and that this library is using the result on restore to the set the ip and mac address. In my opinion this library should not have to know anything about the network status used in podman. I think it would make more sense to handle setting the correct ip and mac entirely in libpod and not here.
The text was updated successfully, but these errors were encountered: