Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the podman network status #6

Closed
Luap99 opened this issue Aug 18, 2021 · 2 comments · Fixed by #7
Closed

Do not use the podman network status #6

Luap99 opened this issue Aug 18, 2021 · 2 comments · Fixed by #7

Comments

@Luap99
Copy link
Contributor

Luap99 commented Aug 18, 2021

Podman is going to abstract CNI from libpod (see containers/podman#11232).
When the work is done libpod will no longer use the CNI result as network status. I am currently wiring the new interface into libpod and noticed that the CNI result is dumped into the checkpoint dir and that this library is using the result on restore to the set the ip and mac address. In my opinion this library should not have to know anything about the network status used in podman. I think it would make more sense to handle setting the correct ip and mac entirely in libpod and not here.

@adrianreber
Copy link
Member

Is that related to #5 ?

@Luap99
Copy link
Contributor Author

Luap99 commented Sep 1, 2021

Is that related to #5 ?

Somewhat, I don't how many consumers this lib has but if GetIPFromNetworkStatus and GetMACFromNetworkStatus are only used by Podman I think it is safe to remove CNI completely. If the functions are also used elsewhere then this has to stay obviously.

Anyway the Podman network status will be changed in containers/podman#11322. When the PR is merged this lib will no longer be able to unmarshal this into a CNI result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants