rootful: unset XDG_RUNTIME_DIR #11195
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Let's see if this breaks anything. |
|
dnsname fix: containers/dnsname#73 |
|
LGTM |
|
LGTM, but I vote we don't backport this to 3.3 and leave it to the 4.0 release in case this does break something |
|
Yeah I am fine with not backporting, but we should get a new dnsname version into 3.3 to fix the linked issues. |
|
Agree with don't back port, although I think we will have a podman 3.4 release. before we ship podman 4.0. |
|
LGTM once @edsantiago 's comment is addressed |
Depending how the user logs in to the root account, XDG_RUNTIME_DIR is set to /run/user/0 or it is unset. For conmon we already set it always to an empty string. The inconsistency is causing issues for the dnsname plugin. To fix it unset XDG_RUNTIME_DIR for the podman process. [NO TESTS NEEDED] Fixes containers#10806 Fixes containers#10745 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
changed the title
|
Verified that os.Unsetenv("foobar") does not return an error. /lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Depending how the user logs in to the root account, XDG_RUNTIME_DIR is
set to /run/user/0 or it is unset. For conmon we already set it always
to an empty string. The inconsistency is causing issues for the dnsname
plugin. To fix it also set XDG_RUNTIME_DIR to an empty string for the
podman process.
Fixes #10806
Fixes #10745