Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: podman login: root authfile path #11725

Closed
edsantiago opened this issue Sep 23, 2021 · 3 comments · Fixed by #11733
Closed

regression: podman login: root authfile path #11725

edsantiago opened this issue Sep 23, 2021 · 3 comments · Fixed by #11733
Assignees
@Luap99
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

#11195 (my guess) broke podman login, in the sense that we can no longer share credentials with skopeo.

# env|grep XDG_R
XDG_RUNTIME_DIR=/run/user/0

[podman 3.3]
# podman login quay.io
...
# find /run -name auth.json
/run/user/0/containers/auth.json       <---- this is good. It respects XDG

[podman 3.4.0-0.4.rc1.fc36]
# podman login quay.io
...
# find /run -name auth.json
/run/containers/0/auth.json            <---- this is BAD

This is caught by one of the system tests in 150-login.bats. The test is passing in CI. My gut feel is that CI doesn't set the magic XDG envariables.
@edsantiago edsantiago mentioned this issue Sep 23, 2021
Closed
@vrothberg
Copy link
Member

@Luap99 PTAL

@Luap99
Copy link
Member

Luap99 commented Sep 24, 2021

I guess we have to revert this commit.
I have another way to fix the original dnsname issue for podman 4.0 but 3.4 would then still have the problem with the dnsname plugin not properly cleanup left over files.

Luap99 added a commit to Luap99/libpod that referenced this issue Sep 24, 2021
@Luap99
Revert "rootful: unset XDG_RUNTIME_DIR"
1cf66f5 
This reverts commit 91e21be.

XDG_RUNTIME_DIR is required for the authfile path. We cannot unset it.

[NO TESTS NEEDED]

Fixes containers#11725

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Sep 24, 2021
Merged
@Luap99
Copy link
Member

Luap99 commented Sep 24, 2021

PR #11733

mheon pushed a commit to mheon/libpod that referenced this issue Sep 29, 2021
@Luap99 @mheon
Revert "rootful: unset XDG_RUNTIME_DIR"
8c94427 
This reverts commit 91e21be.

XDG_RUNTIME_DIR is required for the authfile path. We cannot unset it.

[NO TESTS NEEDED]

Fixes containers#11725

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rootful: do not set XDG_RUNTIME_DIR for cni plugins Luap99/libpod
3 participants
@edsantiago @vrothberg @Luap99