Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure journald events tests only run where supported #11007

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Ensure journald events tests only run where supported #11007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/system/090-events.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ function _events_disjunctive_filters() {

@test "events with disjunctive filters - journald" {
skip_if_remote "remote does not support --events-backend"
skip_if_journald_unavailable "system does not support journald events"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not worth resubmitting for; but should you need to do this again in future, I'd suggest adding "rootless" to the skip message. Potential benefit is ultra-unlikely, though: some sort of system bug causing journald to be unavailable as root, and someone looking at the test logs, and that someone happening to notice the "skip" message for this test (skip messages aren't normally prominent), and that someone noticing the word "rootless" in a rootful test.

_events_disjunctive_filters --events-backend=journald
}

Expand Down