Ensure journald events tests only run where supported #11007
Conversation
We don't support the journald events backend on RHEL8, for example. So we can't unconditionally run these tests. Partial fix for RHBZ1955166 Signed-off-by: Matthew Heon <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -81,6 +81,7 @@ function _events_disjunctive_filters() { | |||
|
|
|||
| @test "events with disjunctive filters - journald" { | |||
| skip_if_remote "remote does not support --events-backend" | |||
| skip_if_journald_unavailable "system does not support journald events" | |||
There was a problem hiding this comment.
Absolutely not worth resubmitting for; but should you need to do this again in future, I'd suggest adding "rootless" to the skip message. Potential benefit is ultra-unlikely, though: some sort of system bug causing journald to be unavailable as root, and someone looking at the test logs, and that someone happening to notice the "skip" message for this test (skip messages aren't normally prominent), and that someone noticing the word "rootless" in a rootful test.
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Forward-port #11006 to main branch, so this doesn't bite us in the future.