Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prune until filter test for podman volume cli #10861

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add prune until filter test for podman volume cli #10861

merged 1 commit into from
Jul 27, 2021

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented Jul 5, 2021 •
edited
Loading

This commit follows work started in #10756. Changes made in #11015
enabled cli support for volume prune --filter until. Adding e2e test
closes #10579.

Fixes #10579

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2021
@jmguzik jmguzik force-pushed the until-prune-volume-cmd branch 2 times, most recently from 6f6877d to d60bfd2 Compare July 6, 2021 22:18
@jmguzik jmguzik mentioned this pull request Jul 8, 2021
Closed
@jmguzik jmguzik force-pushed the until-prune-volume-cmd branch 4 times, most recently from 42ddc77 to 624650d Compare July 16, 2021 22:27
@jmguzik jmguzik marked this pull request as ready for review July 17, 2021 07:56
@jmguzik
Copy link
Contributor Author

jmguzik commented Jul 17, 2021

I think CI failure is not related.

@jmguzik jmguzik changed the title [WIP] Add prune until filter support to podman cli Add prune until filter support to podman cli Jul 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2021
edsantiago
edsantiago suggested changes Jul 20, 2021
View reviewed changes
test/e2e/volume_prune_test.go Outdated Show resolved Hide resolved
@jmguzik jmguzik mentioned this pull request Jul 21, 2021
Merged
jmguzik added a commit to jmguzik/podman that referenced this pull request Jul 21, 2021
@jmguzik
Add until filter to volume ls filters list
2d8e837 
As a conclusion of a discussion in containers#10861, until filter is added
by this commit to volume ls filters.

Signed-off-by: Jakub Guzik <[email protected]>
@jmguzik jmguzik force-pushed the until-prune-volume-cmd branch from 624650d to c4c8729 Compare July 26, 2021 19:45
@jmguzik
Copy link
Contributor Author

jmguzik commented Jul 26, 2021

It seems only e2e test is needed to make it working after changes made in #11015. I changed the commit and PR description. Adjusted it also to your suggestions.

@jmguzik jmguzik changed the title Add prune until filter support to podman cli Add prune until filter test for podman volume cli Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@edsantiago
Copy link
Member

LGTM. It bothers me that until is not documented in podman-volume-prune(1), but that is beyond the scope of your PR.

@jmguzik
Copy link
Contributor Author

jmguzik commented Jul 26, 2021

LGTM. It bothers me that until is not documented in podman-volume-prune(1), but that is beyond the scope of your PR.

I will add it. I should do it earlier, forgot so I will do it now.

@edsantiago
Copy link
Member

Looks like you're also missing a WaitWithDefaultTimeout()

@jmguzik
Add prune until filter test for podman volume cli
7fa4d2c 
This commit follows work started in containers#10756. Changes made in containers#11015
enabled cli support for volume prune --filter until. Adding e2e test
closes containers#10579.

Signed-off-by: Jakub Guzik <[email protected]>
@jmguzik jmguzik force-pushed the until-prune-volume-cmd branch from c4c8729 to 7fa4d2c Compare July 26, 2021 20:38
@jmguzik
Copy link
Contributor Author

jmguzik commented Jul 26, 2021 •
edited
Loading

Looks like you're also missing a WaitWithDefaultTimeout()

Yes, added. I also reviewed the situation in podman-volume-prune(1). Most of the filters were wrong for this command according to:
https://docs.podman.io/en/latest/_static/api.html#operation/VolumePruneLibpod

I updated the info. Good catch, thanks.

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 508dc03 into containers:main Jul 27, 2021
@edsantiago edsantiago mentioned this pull request Aug 31, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago approved these changes

@Luap99 Luap99 Awaiting requested review from Luap99

@vrothberg vrothberg Awaiting requested review from vrothberg

@mheon mheon Awaiting requested review from mheon

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker API incompatibility for "volume prune": "until" is an invalid volume filter
6 participants
@jmguzik @edsantiago @mheon @vrothberg @Luap99 @openshift-merge-robot