Docker API incompatibility for "volume prune": "until" is an invalid volume filter

[w4tsn]

/kind bug

Description

The docker API supports the until filter in volume prunes. This is not stated in the official documentation, interestingly enough, but I'm using this flag on the docker cli client without problems. E.g. until=24h.

Steps to reproduce the issue:

Run `podman volume prune --filter until="24h"

Describe the results you received:

Got an error message from the "docker" API socket

An unexpected docker error occurred: 500 Server Error: Internal Server Error (\"failed to parse filters for until=24h: \"until\" is an invalid volume filter\")

Describe the results you expected:

Compatibility of the "until" filter for volume prune, as it is supported by docker - if wider docker API compatibility is desired here.

Output of podman version:

Version:      3.1.2
API Version:  3.1.2
Go Version:   go1.16.3
Built:        Wed May 12 21:27:59 2021
OS/Arch:      linux/amd64

Output of podman info --debug:

host:
  arch: amd64
  buildahVersion: 1.20.1
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.27-2.fc34.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.27, commit: '
  cpus: 4
  distribution:
    distribution: fedora
    version: "34"
  eventLogger: journald
  hostname: backend05.othermo.de
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.12.8-300.fc34.x86_64
  linkmode: dynamic
  memFree: 15457230848
  memTotal: 16779862016
  ociRuntime:
    name: crun
    package: crun-0.19.1-3.fc34.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.19.1
      commit: 1535fedf0b83fb898d449f9680000f729ba719f5
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: false
    seccompEnabled: true
    selinuxEnabled: true
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 8589930496
  swapTotal: 8589930496
  uptime: 62h 51m 58.74s (Approximately 2.58 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - docker.io
  - quay.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 0
    paused: 0
    running: 0
    stopped: 0
  graphDriverName: overlay
  graphOptions:
    overlay.mountopt: nodev,metacopy=on
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "true"
  imageStore:
    number: 1
  runRoot: /run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 3.1.2
  Built: 1620847679
  BuiltTime: Wed May 12 21:27:59 2021
  GitCommit: ""
  GoVersion: go1.16.3
  OsArch: linux/amd64
  Version: 3.1.2

Package info (e.g. output of rpm -q podman or apt list podman):

podman-3.1.2-3.fc34.x86_64

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)

I did not test with the latest version of podman, but I consulted the guides.

[mheon]

Any chance you can try with 3.2.0? I know that @jmguzik has been doing a lot of work on filters for prune, so it's possible he's implemented this already.

[jmguzik]

@w4tsn @mheon Docker does not support prune until filter for volume. Please refer to:
https://docs.docker.com/engine/api/v1.41/#operation/VolumePrune
This most likely could be implemented in podman, assuming created time is stored somewhere (did not check).

EDIT: cli supports it so this is a strange situation. Support is undocumented thus missed in podman.

[mheon]

We do store volume create time, so this ought to be possible.

[jmguzik]

We do store volume create time, so this ought to be possible.

If so I can assign to this one to do it in end of this- next week.
/assign

[rhatdan]

You got it.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[rhatdan]

@jmguzik Any progress?

[jmguzik]

In progress. Fighting with one thing, but in http api it's done.
Will be done when I finish #10861