Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote: build: does not handle errors #7137

Closed
edsantiago opened this issue Jul 29, 2020 · 1 comment · Fixed by #7452
Closed

podman-remote: build: does not handle errors #7137

edsantiago opened this issue Jul 29, 2020 · 1 comment · Fixed by #7452
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

podman-remote build, if there are errors, will happily exit 0 and with no output.

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ printf "FROM alpine\nRUN false\n" > Containerfile
$ ./bin/podman-remote build -t foo -f Containerfile .
$ echo $?
0

Expected:

$ ./bin/podman build -t foo -f Containerfile .
STEP 1: FROM alpine
STEP 2: RUN false
Error: error building at STEP "RUN false": error while running runtime: exit status 1
$ echo $?
125

(bonus: there is no output in the system server window, either)

@rhatdan
Copy link
Member

rhatdan commented Sep 10, 2020

This continues to be worked on.

jwhonce added a commit to jwhonce/podman that referenced this issue Sep 14, 2020
* Refactor/Rename channel.WriteCloser() to encapsulate the channel
* Refactor build endpoint to "live" stream buildah output channels
  over API rather then buffering output
* Refactor bindings/tunnel build because endpoint changes
  * building tar file now in bindings rather then depending on
    caller
* Cleanup initiating extra image engine
* Remove setting fields to zero values (less noise in code)
* Update tests to support remote builds

Fixes containers#7136
Fixes containers#7137

Signed-off-by: Jhon Honce <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants