Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote: build: does not emit 'STEP' #7136

Closed
edsantiago opened this issue Jul 29, 2020 · 8 comments · Fixed by #7452
Closed

podman-remote: build: does not emit 'STEP' #7136

edsantiago opened this issue Jul 29, 2020 · 8 comments · Fixed by #7452
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Also, other output is out of order, and includes unexpected cruft.

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ printf "FROM alpine\nRUN echo hi\n" >Containerfile
$ ./bin/podman-remote build -t foo -f Containerfile .
hi               <----- what is this doing here? I expected it much farther down below
Getting image source signatures
Copying blob sha256:50644c29ef5a27c9a40c393a73ece2479de78325cae7d762ef3cdc19bf42dd0a
Copying blob sha256:1846819bbfecae935016434cedca6048bea8129532da628c1b5a88c29a77ea66
Copying config sha256:44c079bfdef6a5d51438995fa9dce6e70add2204c2d2dacfc0165e0379d9e650
Writing manifest to image destination
Storing signatures
--> 44c079bfdef
44c079bfdef6a5d51438995fa9dce6e70add2204c2d2dacfc0165e0379d9e650

FROM alpine          <--- expected: STEP 1
RUN echo hi          <--- expected: STEP 2
COMMIT foo           <--- expected: STEP 3
Successfully built 44c079bfdef6a5d51438995fa9dce6e70add2204c2d2dacfc0165e0379d9e650

Comparison against non-remote:

$ ./bin/podman build -t foo -f Containerfile .
STEP 1: FROM alpine
STEP 2: RUN echo hi
hi
STEP 3: COMMIT foo
--> fa3f90c1de0
fa3f90c1de0be86d636cc70d4ca5d817c9d2292f7cb52a681a0c27afdaf30c52
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Jul 29, 2020
@lsm5
Copy link
Member

lsm5 commented Aug 6, 2020

@vrothberg is non-remote podman ideal, or should it also emit the Getting image source signatures and Copying blob.. lines?

@lsm5 lsm5 self-assigned this Aug 6, 2020
@lsm5
Copy link
Member

lsm5 commented Aug 6, 2020

hmm, fwiw, non-remote won't say hi to me :(

$ ./bin/podman build -t foo -f Containerfile .
STEP 1: FROM alpine
STEP 2: RUN echo hi
--> Using cache cb4e7c12b13e5ea2b1ac71dc8405fbb197a3c447e114605dd580b16a981a121d
STEP 3: COMMIT foo
--> cb4e7c12b13
cb4e7c12b13e5ea2b1ac71dc8405fbb197a3c447e114605dd580b16a981a121d

@vrothberg
Copy link
Member

@lsm5 currently remote does not display the information from pulling/pushing or building images.

@baude @jwhonce is that something you want to see? I guess @rhatdan has a growing desire to support that, especially for Win and Mac, but I'm not sure how much work that would be.

@zhangguanzhang
Copy link
Collaborator

hmm, fwiw, non-remote won't say hi to me :(

$ ./bin/podman build -t foo -f Containerfile .
STEP 1: FROM alpine
STEP 2: RUN echo hi
--> Using cache cb4e7c12b13e5ea2b1ac71dc8405fbb197a3c447e114605dd580b16a981a121d
STEP 3: COMMIT foo
--> cb4e7c12b13
cb4e7c12b13e5ea2b1ac71dc8405fbb197a3c447e114605dd580b16a981a121d

I see the Using cache

[root@sz-test temp]# vi Containerfile 
[root@sz-test temp]# ../podman/bin/podman build -t foo -f Containerfile .
STEP 1: FROM docker.io/zhangguanzhang/alpine:latest
STEP 2: RUN echo hi
hi
STEP 3: COMMIT foo
--> faea0e66e6e
faea0e66e6ed18c284f79fb7eae75b446b3c9fddb880bc01501ce8dea7029332
[root@sz-test temp]# ../podman/bin/podman build -t foo -f Containerfile .
STEP 1: FROM docker.io/zhangguanzhang/alpine:latest
STEP 2: RUN echo hi
--> Using cache faea0e66e6ed18c284f79fb7eae75b446b3c9fddb880bc01501ce8dea7029332
STEP 3: COMMIT foo
--> faea0e66e6e
faea0e66e6ed18c284f79fb7eae75b446b3c9fddb880bc01501ce8dea7029332

@lsm5
Copy link
Member

lsm5 commented Aug 6, 2020

@zhangguanzhang thanks!

@vrothberg So, podman-remote doesn't seem to be using cache either as I can see the message echoed everytime. That should also be made similar to non-remote, yes?

@lsm5 lsm5 assigned jwhonce and unassigned lsm5 Aug 6, 2020
@vrothberg
Copy link
Member

@zhangguanzhang thanks!

@vrothberg So, podman-remote doesn't seem to be using cache either as I can see the message echoed everytime. That should also be made similar to non-remote, yes?

Yes, a server-side cache could be quite helpful.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Sep 10, 2020

@jwhonce Has this fix been merged yet?

jwhonce added a commit to jwhonce/podman that referenced this issue Sep 14, 2020
* Refactor/Rename channel.WriteCloser() to encapsulate the channel
* Refactor build endpoint to "live" stream buildah output channels
  over API rather then buffering output
* Refactor bindings/tunnel build because endpoint changes
  * building tar file now in bindings rather then depending on
    caller
* Cleanup initiating extra image engine
* Remove setting fields to zero values (less noise in code)
* Update tests to support remote builds

Fixes containers#7136
Fixes containers#7137

Signed-off-by: Jhon Honce <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants