Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] podman events health_status generated: no output #18071

Closed
edsantiago opened this issue Apr 5, 2023 · 0 comments · Fixed by #18074
Closed

[e2e] podman events health_status generated: no output #18071

edsantiago opened this issue Apr 5, 2023 · 0 comments · Fixed by #18074
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Seen in remote f37 root.

podman events health_status generated
...
# podman-remote [options] run --name test-hc -dt --health-cmd echo working busybox
72fccf0b07490697ea83c1994b9a8a4f1fbdcc0e06c2e9b36c304f9f00905dee
# podman-remote [options] healthcheck run test-hc
# podman-remote [options] events --stream=false --filter event=health_status --since 1m
...
Failure [1.601 seconds]
...
Number of health_status events
Expected
    <[]string | len:0, cap:0>: nil
not to be empty

I don't see any obvious bug, so, filing.
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Apr 5, 2023
edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 5, 2023
@edsantiago
e2e tests: fix racy flakes
761eca9 
...mostly just test code that wasn't doing the required waits.

My first approach in the kube-play test was to add "--wait".
Bit mistake! The --wait flag, counterintuitively and counter to
documentation, actually destroys all pods+containers+everything
on exit. (Or tries -- see containers#17803). Since this violates POLA
and is undocumented, I include here a fix to the man page.

Despite my best intentions, I can't reasonably check every single
test for missing waits, especially in kube-play where failing
containers will get retried forever so we can't wait. We'll
just have to fix flakes as we see them.

Fixes: containers#17958
Fixes: containers#18071

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this issue Apr 5, 2023
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e tests: fix racy flakes edsantiago/libpod
1 participant
@edsantiago