Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: play kube symlink: missing hello #17958

Closed
edsantiago opened this issue Mar 28, 2023 · 0 comments · Fixed by #18074
Closed

e2e: play kube symlink: missing hello #17958

edsantiago opened this issue Mar 28, 2023 · 0 comments · Fixed by #18074
Labels
flakes Flakes from Continuous Integration Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

  podman play kube should be able to run image where workdir is a symlink
...
Expected
      <string>: 
  to contain substring
      <string>: hello

in int remote f37 root sqlite

To my untrained eye it looks like a race:

kube := podmanTest.Podman([]string{"play", "kube", kubeYaml})
kube.WaitWithDefaultTimeout()
Expect(kube).Should(Exit(0))
logs := podmanTest.Podman([]string{"pod", "logs", "-c", "test-symlink-test-symlink", "test-symlink"})
logs.WaitWithDefaultTimeout()
Expect(logs).Should(Exit(0))
Expect(logs.OutputToString()).To(ContainSubstring("hello"))

(there should be a "wait" somewhere, either --wait in the play, or a subsequent podman wait). Hardly seems worth the effort of filing an issue, it'd be quicker to just fix it in a PR... but the correct solution is to walk through the entire test file and look for other such issues, and that's a job for later.

@edsantiago edsantiago added Good First Issue This issue would be a good issue for a first time contributor to undertake. flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. labels Mar 28, 2023
edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 5, 2023
...mostly just test code that wasn't doing the required waits.

My first approach in the kube-play test was to add "--wait".
Bit mistake! The --wait flag, counterintuitively and counter to
documentation, actually destroys all pods+containers+everything
on exit. (Or tries -- see containers#17803). Since this violates POLA
and is undocumented, I include here a fix to the man page.

Despite my best intentions, I can't reasonably check every single
test for missing waits, especially in kube-play where failing
containers will get retried forever so we can't wait. We'll
just have to fix flakes as we see them.

Fixes: containers#17958
Fixes: containers#18071

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant