Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote push gives no output #14971

Closed
vrothberg opened this issue Jul 19, 2022 · 4 comments · Fixed by #15022
Closed

remote push gives no output #14971

vrothberg opened this issue Jul 19, 2022 · 4 comments · Fixed by #15022
Assignees
@vrothberg
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@vrothberg
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description
podman-remote push does not print any output.

Steps to reproduce the issue:

podman (main) $ ./bin/podman-remote push localhost:5000/nginx

Describe the results you received:

No output.

Describe the results you expected:

Output.

@containers/podman-maintainers let's fix this before the v4.2 release.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 19, 2022
@vrothberg
Copy link
Member Author

Also happens with Podman v4.1.1. I wonder how/why we did not catch that in CI.

@vrothberg vrothberg mentioned this issue Jul 19, 2022
Merged
@mheon
Copy link
Member

mheon commented Jul 19, 2022

This is separate from progress bars, yes? Printing a digest?

@vrothberg
Copy link
Member Author

This is a separate issue. There is no output at all at the moment but it should print the copy $digest lines etc.

@vrothberg vrothberg self-assigned this Jul 21, 2022
@vrothberg
Copy link
Member Author

I'll tackle this one now.

@vrothberg vrothberg mentioned this issue Jul 21, 2022
Merged
vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 21, 2022
@vrothberg
remote push: show copy progress
b79ac0a 
`podman-remote push` has shown absolutely no progress at all. Fix that
by doing essentially the same as the remote-pull code does.

The get-free-out-of-jail-card for backwards compatibility is to let the
`quiet` parameter default to true.  Since the --quioet flag wasn't
working before either, older Podman clients do not set it.

Also add regression tests to make sure we won't regress again.

Fixes: containers#11554
Fixes: containers#14971
Signed-off-by: Valentin Rothberg <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jul 26, 2022
@vrothberg @mheon
remote push: show copy progress
fde39ed 
`podman-remote push` has shown absolutely no progress at all. Fix that
by doing essentially the same as the remote-pull code does.

The get-free-out-of-jail-card for backwards compatibility is to let the
`quiet` parameter default to true.  Since the --quioet flag wasn't
working before either, older Podman clients do not set it.

Also add regression tests to make sure we won't regress again.

Fixes: containers#11554
Fixes: containers#14971
Signed-off-by: Valentin Rothberg <[email protected]>
@YoitoFes YoitoFes mentioned this issue Aug 5, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remote push: show copy progress vrothberg/libpod
2 participants
@mheon @vrothberg