-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman-remote push doesn't report progress like local podman does #11554
Comments
I think that is your problem, it is yet another shortcoming of When pushing (and pulling) images with podman on Linux, there is progress...
Maybe try running |
Side note: info would be more useful, if this also included the "variant" ?
systemd's /etc/os-release:
Not sure why it is being called distribution.distribution, instead of distribution.name ? I fully understand why it is called "distribution" and not "operating system", though...
|
@jwhonce PTAL, I think we need to add progress support to the push endpoints for APIv2. |
That works, but I'm pushing to a private registry (gcr.io), so I'd need to set up authentication to GCP on that machine. I'll just tough it out without the progress. It would be nice to have on MacOS though. Thanks! |
Note that this may require some massaging in containers/image. The progress bars are only using stdout if it's TTY (see https://github.com/containers/image/blob/main/copy/copy.go#L223-L226). Probably need to hijack the connection in the server (opt-in)? @jwhonce WDYT? |
@vrothberg If we pull the TTY test into the caller code then it can decide whether and how to present to the "user". I would suggest a cancelable channel to pass back the progress. |
A friendly reminder that this issue had no activity for 30 days. |
@jwhonce @vrothberg any progress on this? |
Not to my knowledge. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
do we need an issue to track the change needed in containers/image? |
@jmguzik this may be something for you :) |
/assign @jmguzik |
In the scope of #14886 I implemented a solution similar to the docker one (for pull operation), but there is another option that has to be explored for which I, unfortunately, don't have time right now. The attached PR should provide more information. cc @vrothberg |
/unassign @jmguzik |
Thanks for pushing things forward, @jmguzik! I added the needs-design-doc label to make sure we find consensus on the design before continuing implementing. |
Responding here in response to an idea in #14886, I don't think it's necessary to keep the exact same progress bar output. From my staindpoint, the progress output is for interactive, human-readable sessions, and I just want to see the general progress and make sure things aren't stuck. I don't see why anyone would write scripts around the progress bars. Scripting should be done via return codes and formatted output like JSON. |
I agree they don't need to be the same. Just similar. |
Being worked on in #15022 |
@umohnani8 I think #15022 is about fixing to have any output and not moving forward with progress bars. |
#15022 will fix this issue. |
Yes, that is the request in this issue. Once we have figured out how pull progress bars will work, the ones for push will work in the same way. |
`podman-remote push` has shown absolutely no progress at all. Fix that by doing essentially the same as the remote-pull code does. The get-free-out-of-jail-card for backwards compatibility is to let the `quiet` parameter default to true. Since the --quioet flag wasn't working before either, older Podman clients do not set it. Also add regression tests to make sure we won't regress again. Fixes: containers#11554 Fixes: containers#14971 Signed-off-by: Valentin Rothberg <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
When I run...
Podman doesn't provide any feedback in the console about the progress of the push, like
docker push
does. Here's an example of whatdocker push
outputs:It also will show the size and progress of each layer as it's pushing. This feedback is something many docker users are familiar with and gives the user assurance that podman is doing what it's supposed to.
Steps to reproduce the issue:
Run
podman push $IMAGE_TAG
on any image you have locally.Confirm that the console does not provide progress feedback.
Describe the results you received:
No results.
Describe the results you expected:
Described above.
Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):I'm pushing images from MacOS, so I ran
brew desc podman
here...Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)
Yes
Additional environment details (AWS, VirtualBox, physical, etc.):
I asked about this in the #crio Kubernetes Slack Channel and was told to report an issue here, so here I am.
Thanks! 🤗
The text was updated successfully, but these errors were encountered: