Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label length vs kubernetes #13962

Closed
rhatdan opened this issue Apr 21, 2022 Discussed in #13901 · 0 comments · Fixed by #14023
Closed

label length vs kubernetes #13962

rhatdan opened this issue Apr 21, 2022 Discussed in #13901 · 0 comments · Fixed by #14023
Labels
kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2022

Discussed in #13901

Originally posted by nivekuil April 17, 2022
Podman labels don't have the tight constraints (63 chars) that k8s labels do. Is this intended? It's handy to rely on this to filter for pods with a certain label key through the API, which is not possible with annotations (the k8s compatible way).

@rhatdan rhatdan added the kube label Apr 21, 2022
@rhatdan rhatdan mentioned this issue Apr 26, 2022
Merged
rhatdan added a commit to rhatdan/podman that referenced this issue Apr 27, 2022
@rhatdan
Truncate annotations when generating kubernetes yaml files
7259a63 
Kubernetes only allows 63 characters in an annotation.  Make sure
that we only add 63 or less charaters when generating kube. Warn
if containers or pods have longer length and truncate.

Discussion: containers#13901

Fixes: containers#13962

Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Truncate annotations when generating kubernetes yaml files rhatdan/podman
1 participant
@rhatdan