label length vs kubernetes

[nivekuil]

Podman labels don't have the tight constraints (63 chars) that k8s labels do. Is this intended? It's handy to rely on this to filter for pods with a certain label key through the API, which is not possible with annotations (the k8s compatible way).

[nivekuil]

I just realized that there isn't even a way to put annotations on pods in Podman. Bug? Use case is running an OCI hook, which can filter on annotation, on pod start.

[rhatdan]

Please open separate issues for each one of these. Podman labels have no limits, but if you believe we should constrain podman play kube to only allow 63 chars and have podman generate kube truncate labels at 63 chars, with a warning, we would consider it.

[nivekuil]

On further thought podman is forced to break compatibility with something here, since docker labels are unlimited. These may map more cleanly to k8s annotations but that ship has sailed and would be confusing anyway. As such I don't really think there's a standard to follow so it seems fine that pods can't be annotated, or at least I don't have an actual problem to be solved there. Apr 18, 2022 3:27:54 AM Daniel J Walsh ***@***.***>:

…

Please open separate issues for each one of these. Podman labels have no limits, but if you believe we should constrain podman play kube to only allow 63 chars and have podman generate kube truncate labels at 63 chars, with a warning, we would consider it. — Reply to this email directly, view it on GitHub[#13901 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABDLDWEMKFWI3ONHYNWY2ITVFU2KTANCNFSM5TTOUU2Q]. You are receiving this because you authored the thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAySURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeDVulAABbzDScQAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/ABDLDWDJ7BJSSNBKNKDZWCTVFU2KTA5CNFSM5TTOUU22YY3PNVWWK3TUL52HS4DFWFCGS43DOVZXG2LPNZBW63LNMVXHJKTDN5WW2ZLOORPWSZGOAATXE5Q.gif]

[rhatdan]

What do you think @haircommander @umohnani8 ?

[mheon]

Best solution would seem to be to limit length accepted by podman play kube (and warn on podman generate kube generating YAML with too-long labels), but do not change how podman run and similar handle labels.

[rhatdan]

SGTM