Skip to content

Commit

Permalink
Merge pull request #7828 from edsantiago/bats
Browse files Browse the repository at this point in the history
System tests: corner case for run --pull
  • Loading branch information
openshift-merge-robot authored Sep 29, 2020
2 parents 12f173f + 81d9ba5 commit 453333a
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion test/system/030-run.bats
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,23 @@ echo $rand | 0 | $rand
run_podman run --pull=always $NONLOCAL_IMAGE true
is "$output" "Trying to pull .*" "--pull=always [with image PRESENT]: re-fetches"

# Very weird corner case fixed by #7770: 'podman run foo' will run 'myfoo'
# if it exists, because the string 'foo' appears in 'myfoo'. This test
# covers that, as well as making sure that our testimage (which is always
# tagged :YYYYMMDD, never :latest) doesn't match either.
run_podman tag $IMAGE my${PODMAN_TEST_IMAGE_NAME}:latest
run_podman 125 run --pull=never $PODMAN_TEST_IMAGE_NAME true
is "$output" "Error: unable to find a name and tag match for $PODMAN_TEST_IMAGE_NAME in repotags: no such image" \
"podman run --pull=never with shortname (and implicit :latest)"

# ...but if we add a :latest tag (without 'my'), it should now work
run_podman tag $IMAGE ${PODMAN_TEST_IMAGE_NAME}:latest
run_podman run --pull=never ${PODMAN_TEST_IMAGE_NAME} cat /home/podman/testimage-id
is "$output" "$PODMAN_TEST_IMAGE_TAG" \
"podman run --pull=never, with shortname, succeeds if img is present"

run_podman rm -a
run_podman rmi $NONLOCAL_IMAGE
run_podman rmi $NONLOCAL_IMAGE {my,}${PODMAN_TEST_IMAGE_NAME}:latest
}

# 'run --rmi' deletes the image in the end unless it's used by another container
Expand Down

0 comments on commit 453333a

Please sign in to comment.