Use latest aardvark-dns binary #344
Conversation
|
this should fix #308 |
|
To be clear: The new images I'm building are not required in this PR. I'm just referencing it in case someone wonders how/where/why in the future. |
|
LGTM just waiting for unresolved comments and discussion above. |
|
/lgtm |
There was a problem hiding this comment.
If we leave AARDVARK_DNS_BRANCH undefined Cirrus will default to main which will silently do the wrong thing when a new release-branch is created in the future.
Since you'll need to re-run the tests again anyway, I've got newly built images with the netavark/aardvark-dns packages installed + binaries stripped out. It's up to you if you want to incorporate them here, or I'm fine if that happens in another PR:
- GCE image ID is c5353795591864320
- fedora-aws is ami-09e5978f141900855
- fedora-netavark-aws-arm64 is ami-00d7ccde5eaacc50e
- fedora-podman-aws-arm64 is ami-02da46d8fa51e5316
|
Sorry @baude these kinds of changes can be so finicky to get right. I do appreciate you're taking the initiative to open this PR and start the work. With the Updating the images is optional, and arguably risky. Totally fine if that happens in another PR. |
|
/hold |
Instead of using a packaged version of aardvark-dns, we grabbed the latest main branch zip copy and use it instead. Signed-off-by: Brent Baude <[email protected]>
|
/hold @cevich I think build_cross is failing with new image |
|
Is it missing |
|
No it is missing netavark which makes podman fall back to cni which then errors because cni is missing. I don't understand why we exclude the netavark rpms. |
It's using the cross-rs tool to call podman, not sure if you can specify options like that. I say we just ignore the failure and manually merge, since @lsm5 PR can probably get merged really soon. |
SGTM if others are cool with it. |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Cool lets wait for #338 then |
|
Ugh, so 338 is going to need some more time. I've got an idea... |
|
/lgtm |
|
@cevich Looks like total success depends on build_cross, we gotta remove that dependency as well. |
|
Oof, isn't that what I just did? Hrmmm. What did I miss. |
|
oh the artifact. crap. |
|
right. aardvark CI needs that 🤣 |
A future commit will bring in native ARM64 builds. Until then, some adjustments are needed to handle the gutted netavark/aardvark RPMs causing podman (needed indirectly by cross-rs) to fail due to no networking. Signed-off-by: Chris Evich <[email protected]>
|
Okay, so hopefully that will get it. Once again for the third-time 😖 |
|
Okay, that's going to work. Anyone: please feel free to merge this assuming it passes and looks good. I've got to get some lunch. |
|
/lgtm |
Instead of using a packaged version of aardvark-dns, we grabbed the
latest main branch zip copy and use it instead.
Signed-off-by: Brent Baude [email protected]