Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: enable Fedora 36 aarch64 tasks on EC2 #338

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Cirrus: enable Fedora 36 aarch64 tasks on EC2 #338

merged 1 commit into from
Jul 15, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 13, 2022

Signed-off-by: Lokesh Mandvekar [email protected]

@lsm5 lsm5 force-pushed the ec2-aarch64 branch 7 times, most recently from 7f9e18d to 8d25856 Compare July 14, 2022 20:09
@lsm5 lsm5 requested a review from cevich July 14, 2022 20:11
@lsm5 lsm5 marked this pull request as ready for review July 14, 2022 20:11
cevich
cevich reviewed Jul 14, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
cevich
cevich approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You kept it close to the aardvark work which helps. Just a minor nit and a question. Otherwise LGTM assuming the tests are also green.

Makefile Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
cevich
cevich approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lsm5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2022

@cevich lemme know if you got any ideas about the success task and CIRRUS_BUILD_ID. Else, maybe it's worthwhile to just change across the board to use rpms from rhcontainerbot/podman-next and get rid of the binary.zip part right away. I was hoping to delay that a bit.

@lsm5
Copy link
Member Author

lsm5 commented Jul 15, 2022

@cevich Made some more changes to get rid of binary.zip in success task. If you're cool with the recent changes I can squash commits and re-push.

cevich
cevich reviewed Jul 15, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
cevich
cevich reviewed Jul 15, 2022
View reviewed changes
contrib/cirrus/setup.sh Outdated Show resolved Hide resolved
cevich
cevich reviewed Jul 15, 2022
View reviewed changes
contrib/cirrus/setup.sh Outdated Show resolved Hide resolved
@lsm5 lsm5 force-pushed the ec2-aarch64 branch 2 times, most recently from fde5899 to 539fecf Compare July 15, 2022 14:27
@lsm5
Copy link
Member Author

lsm5 commented Jul 15, 2022

image ids updated per containers/automation_images#149 (comment)

@cevich cevich mentioned this pull request Jul 15, 2022
Merged
@lsm5 lsm5 mentioned this pull request Jul 15, 2022
Closed
@openshift-ci openshift-ci bot removed the lgtm label Jul 15, 2022
@lsm5 lsm5 mentioned this pull request Jul 15, 2022
Closed
cevich
cevich reviewed Jul 15, 2022
View reviewed changes
contrib/cirrus/setup.sh Outdated Show resolved Hide resolved
cevich
cevich reviewed Jul 15, 2022
View reviewed changes
.cirrus.yml Outdated Show resolved Hide resolved
@lsm5 lsm5 force-pushed the ec2-aarch64 branch 3 times, most recently from 46c00f3 to 40c3331 Compare July 15, 2022 20:01
cevich
cevich reviewed Jul 15, 2022
View reviewed changes
.cirrus.yml Show resolved Hide resolved
@lsm5 lsm5 force-pushed the ec2-aarch64 branch 3 times, most recently from 130f402 to 75251e5 Compare July 15, 2022 20:40
@cevich
Copy link
Member

cevich commented Jul 15, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2022
@cevich
Copy link
Member

cevich commented Jul 15, 2022

/hold cancel

@openshift-ci openshift-ci bot merged commit 6c682ae into containers:main Jul 15, 2022
@lsm5 lsm5 deleted the ec2-aarch64 branch July 15, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cevich cevich cevich approved these changes

Assignees

@cevich cevich

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @cevich