support for macvlan & ipvlan added.

[kunalkushwaha]

CNI plugins for macvlan and ipvlan will be invoked
instead treating them as user defined network

Signed-off-by: Kunal Kushwaha [email protected]

[kunalkushwaha]

Currently, if ipvlan or macvlan is provided as option for container network, it treats as user defined network and skip the network creation using CNI plugin.

Since with CNI default setup, both macvlan and ipvlan is provided, support for both will be good addition.

e.g.

podman  run -it --rm --network=macvlan busybox sh

[giuseppe]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, kunalkushwaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[mheon]

Can we please do this without overloading --net anymore? That flag has gotten ridiculous to parse

[mheon]

Also - does this actually hit CNI at any point? I don't know if specifying macvlan actually does anything without a CNI network explicitly named "macvlan"

[kunalkushwaha]

This issues is fixed with #2796.

Also - does this actually hit CNI at any point? I don't know if specifying macvlan actually does anything without a CNI network explicitly named "macvlan

@mheon Thanks for pointing it out. I realized now, it was being created as bridge network, even macvlan or ipvlan was passed.

Closing this PR as its fixed with #2796.