Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/storage #1820

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Vendor in containers/storage #1820

merged 1 commit into from
Nov 15, 2018

Conversation

TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat [email protected]

Update containers/storage to get a number of recent fixes there such as: containers/storage#240, containers/storage#239, containers/storage#236, containers/storage#235, containers/storage#234 and maybe a bit more.

Signed-off-by: TomSweeneyRedHat <[email protected]>
@mheon
Copy link
Member

mheon commented Nov 15, 2018

/approve
LGTM
@baude @rhatdan @umohnani8 PTAL

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2018
@mheon
Copy link
Member

mheon commented Nov 15, 2018

Want to get this one in before cutting a release, has some significant bugfixes

@baude
Copy link
Member

baude commented Nov 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2018
@umohnani8
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented Nov 15, 2018

bot, retest this please

1 similar comment
@mheon
Copy link
Member

mheon commented Nov 15, 2018

bot, retest this please

@mheon
Copy link
Member

mheon commented Nov 15, 2018

Papr is down, merging manually.

@mheon mheon merged commit 2868012 into containers:master Nov 15, 2018
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/storeven1 branch November 15, 2018 20:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants