Refactor: Extract ParseIDMap func to idtools package #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
extract-idmap-parser
branch
from
c346f41 to
f07f3c6
Compare
where it belongs. I have noticed that this parsing gets spread across projects. Basically, the very same method is present in libpod, buildah, and cri-o projects. We better start re-using this code from single place or soon everyone has its own version. Signed-off-by: Šimon Lukašík <[email protected]>
isimluk
force-pushed
the
extract-idmap-parser
branch
from
f07f3c6 to
7b209d3
Compare
|
LGTM, |
Of course, Happy to do that. |
|
LGTM, very nice bit of code clean up @isimluk |
|
LGTM |
This was referenced Nov 15, 2018
isimluk
added a commit
to isimluk/libpod
that referenced
this pull request
Dec 23, 2018
ParseIDMap function was extracted to idtools in
containers/storage#236
it is already used in containers/storage and buildah, it should be used in
libpod as well.
Signed-off-by: Šimon Lukašík <[email protected]>
isimluk
added a commit
to isimluk/libpod
that referenced
this pull request
Dec 23, 2018
ParseIDMap function was extracted to idtools in
containers/storage#236
it is already used in containers/storage and buildah, it should be used in
libpod as well.
Signed-off-by: Šimon Lukašík <[email protected]>
isimluk
added a commit
to isimluk/cri-o
that referenced
this pull request
Apr 7, 2019
ParseIDMap function was extracted to idtools in
containers/storage#236
it is already used in containers/storage and buildah and libpod. Cri-o should
use the very same code as the others.
Signed-off-by: Šimon Lukašík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where it belongs.
I have noticed that this parsing gets spread across projects. For instance note
that buildah bundles the same method in utils. We better start re-using this
code from single place.
Signed-off-by: Šimon Lukašík [email protected]