Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: set HOME to root if the user not found #599

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

giuseppe
Copy link
Member

if there is no HOME env variable set and the user is not found, then
set the home directory to '/'.

Signed-off-by: Giuseppe Scrivano [email protected]

vrothberg added a commit to vrothberg/libpod that referenced this pull request Feb 16, 2021
Make sure to not set an empty $HOME for containers and let it default to
"/".

containers/crun#599 is required to fully
address containers#9378.

Partially-Fixes: containers#9378
Signed-off-by: Valentin Rothberg <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

if there is no HOME env variable set and the user is not found, then
set the home directory to '/'.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2021

LGTM

@rhatdan rhatdan merged commit af27f6e into containers:master Feb 17, 2021
mheon pushed a commit to mheon/libpod that referenced this pull request Feb 18, 2021
Make sure to not set an empty $HOME for containers and let it default to
"/".

containers/crun#599 is required to fully
address containers#9378.

Partially-Fixes: containers#9378
Signed-off-by: Valentin Rothberg <[email protected]>

<MH: Fixed cherry-pick conflicts>

Signed-off-by: Matthew Heon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants