utils: set HOME to root if the user not found

if there is no HOME env variable set and the user is not found, then set the home directory to '/'. Signed-off-by: Giuseppe Scrivano <[email protected]>
containers · Feb 16, 2021 · a6eb8a8 · a6eb8a8
1 parent d611a40
commit a6eb8a8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/libcrun/utils.c b/src/libcrun/utils.c
@@ -1157,7 +1157,8 @@ set_home_env (uid_t id)
   if (stream == NULL)
     {
       if (errno == ENOENT)
-        return 0;
+        goto exit;
+
       return -1;
     }
 
@@ -1186,6 +1187,10 @@ set_home_env (uid_t id)
           return 0;
         }
     }
+
+ exit:
+  /* If the user was not found, set it to something reasonable.  */
+  setenv ("HOME", "/", 1);
   return 0;
 }
 

diff --git a/tests/test_start.py b/tests/test_start.py
@@ -217,6 +217,18 @@ def notify_server():
                     pass
             return 0
 
+def test_empty_home():
+    conf = base_config()
+    conf['process']['args'] = ['/sbin/init', 'printenv', 'HOME']
+    add_all_namespaces(conf)
+    try:
+        out, _ = run_and_get_output(conf)
+        if "/" not in str(out):
+            return -1
+    except Exception as e:
+        return -1
+    return 0
+
 all_tests = {
     "start" : test_start,
     "start-override-config" : test_start_override_config,
@@ -228,6 +240,7 @@ def notify_server():
     "test-cwd-relative": test_cwd_relative,
     "test-cwd-relative-subdir": test_cwd_relative_subdir,
     "test-cwd-absolute": test_cwd_absolute,
+    "empty-home": test_empty_home,
 }
 
 if __name__ == "__main__":