Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libcrun_setup_terminal_ptmx #1528

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Aug 20, 2024

Since #1214 it is a no-op and does nothing more than call set_raw.

This does change the public interface of libcrun / break backwards compatibility.

Since containers#1214 it is a no-op and
does nothing more than call set_raw.

Signed-off-by: Nils <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe giuseppe merged commit 457d02a into containers:main Aug 20, 2024
29 of 56 checks passed
@NilsIrl NilsIrl deleted the patch-1 branch August 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants