Refactor: Restore serial settings for incorrect serial #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a utility on a board and running it via a serial console, an issue arises where the output becomes corrupted after executing a command, rendering the terminal unusable. Analyzing the strace output reveals that the code responsible for backing up the serial connection settings from the console's file descriptor restores them to file descriptor 0 instead of the intended console's file descriptor. This circumstance leads to the problem at hand. The proposed fix resolves this issue by addressing the aforementioned scenario. Signed-off-by: Alessandro Carminati <[email protected]> Signed-off-by: Alessandro Carminati <[email protected]>
|
After this change, what is the purpose of the |
NilsIrl
added a commit
to NilsIrl/crun
that referenced
this pull request
Aug 20, 2024
Since containers#1214 it is a no-op and does nothing more than call set_raw. Signed-off-by: Nils <[email protected]>
NilsIrl
added a commit
to NilsIrl/crun
that referenced
this pull request
Aug 20, 2024
Since containers#1214 it is a no-op and does nothing more than call set_raw. Signed-off-by: Nils <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a utility on a board and running it via a serial console, an issue arises where the output becomes corrupted after executing a command, rendering the terminal unusable.
Analyzing the strace output reveals that the code responsible for backing up the serial connection settings from the console's file descriptor restores them to file descriptor 0 instead of the intended console's file descriptor.
This circumstance leads to the problem at hand.
The proposed fix resolves this issue by addressing the aforementioned scenario.