WIP: Add file based log driver #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the API to allow multiple log drivers in parallel. We can later on support other drivers like files to log into multiple destinations. Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
log-file
branch
from
bfaa802 to
bf0cdde
Compare
This allows to add a file based log driver in a pre-defined path. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
log-file
branch
from
bf0cdde to
0a97500
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 31.91% 31.00% -0.92%
==========================================
Files 13 13
Lines 1131 1129 -2
Branches 423 429 +6
==========================================
- Hits 361 350 -11
- Misses 485 500 +15
+ Partials 285 279 -6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows to add a file based log driver in a pre-defined path.
Which issue(s) this PR fixes:
Refers to #740
Special notes for your reviewer:
Requires #770
Does this PR introduce a user-facing change?