WIP: Allow multiple log drivers to be specified #770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
multi-drivers
branch
2 times, most recently
from
3577381 to
34ead10
Compare
This extends the API to allow multiple log drivers in parallel. We can later on support other drivers like files to log into multiple destinations. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
multi-drivers
branch
from
34ead10 to
39bdb3f
Compare
| /// The logging driver used by the conmon server. | ||
| log_driver: LogDriver, | ||
| /// The logging drivers used by the server. Can be specified multiple times. | ||
| log_drivers: Vec<LogDriver>, |
There was a problem hiding this comment.
unfortunately, I think we need to keep both. We can drop log_driver when conmon-rs moves to 1.0
saschagrunert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This extends the API to allow multiple log drivers in parallel. We can later on support other drivers like files to log into multiple destinations.
Which issue(s) this PR fixes:
Part of #740
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?