Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport podman fix 11933 #840

Merged

Conversation

vrothberg
Copy link
Member

Backports for fixing containers/podman#12410 (comment) plus version bumps.

@containers/podman-maintainers PTAL
Cc: @mheon

Add pkg/flag to properly parse optional bools.  Skopeo is using this
code in `cmd/skopeo` for parsing the `--tls-verify` flag.  Moving the
code into a new package here allows for code share.

Backport of commit 82bebf3 for fixing an issue in Podman v3.4.

Signed-off-by: Valentin Rothberg <[email protected]>
* add pkg/flag from Skopeo (backport)

Signed-off-by: Valentin Rothberg <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Nov 30, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 27a68ec into containers:v0.44 Nov 30, 2021
@vrothberg vrothberg deleted the backport-podman-fix-11933 branch November 30, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants