Cirrus: Use config. in common with all repos. #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes bring the YAML configuration and testing-image in-line with practices and format used by all other containers-org. repos. The intention is to make it easier to maintain by maintaining configuration and behavior hegemony. Also, besides limiting flakes and surprises, utilizing a pre-built container image avoids wasting time installing packages at runtime. Lastly, remove resource constraints on containers so they operate with the maximum available. This is more practical, given there is but a single testing task and no parallelism is needed. Signed-off-by: Chris Evich <[email protected]>
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks, @cevich ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring the YAML configuration and testing-image in-line
with practices and format used by all other containers-org. repos. The
intention is to make it easier to maintain by maintaining configuration
and behavior hegemony. Also, besides limiting flakes and surprises,
utilizing a pre-built container image avoids wasting time installing
packages at runtime. Lastly, remove resource constraints on containers
so they operate with the maximum available. This is more practical,
given there is but a single testing task and no parallelism is needed.
Signed-off-by: Chris Evich [email protected]