-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libimage: add save tests #551
libimage: add save tests #551
Conversation
Add save tests. Also fix a bug when saving a single image but with multiple tags. Signed-off-by: Valentin Rothberg <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cevich, could we recycle some pre-built container images (e..g, from libpod CI) here? It takes around 6 to 7 minutes until all packages etc. are installed and I'd love the polar bears to stay a little longer. I added a bunch of packages to install lately and would love to clean up my mess :^) |
LGTM |
@edsantiago PTAL |
@vrothberg you probably want to rebase. There's a change on master that should make it run a lot faster. |
...err wait...I thought I fixed it...Woops, seems I never actually opened a PR 😊 |
merge me before vendor dance |
[please do not gate on me. I do not have the background knowledge to review this] |
/lgtm |
Add save tests. Also fix a bug when saving a single image but with
multiple tags.
Signed-off-by: Valentin Rothberg [email protected]
@rhatdan @containers/podman-maintainers PTAL