Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: add save tests #551

Merged
merged 1 commit into from
May 17, 2021

Conversation

vrothberg
Copy link
Member

Add save tests. Also fix a bug when saving a single image but with
multiple tags.

Signed-off-by: Valentin Rothberg [email protected]

@rhatdan @containers/podman-maintainers PTAL

Add save tests.  Also fix a bug when saving a single image but with
multiple tags.

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

@cevich, could we recycle some pre-built container images (e..g, from libpod CI) here? It takes around 6 to 7 minutes until all packages etc. are installed and I'd love the polar bears to stay a little longer.

I added a bunch of packages to install lately and would love to clean up my mess :^)

@rhatdan
Copy link
Member

rhatdan commented May 14, 2021

LGTM
@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented May 14, 2021

@edsantiago PTAL
@containers/podman-maintainers PTAL
LGTM

@cevich
Copy link
Member

cevich commented May 14, 2021

@vrothberg you probably want to rebase. There's a change on master that should make it run a lot faster.

@cevich
Copy link
Member

cevich commented May 14, 2021

...err wait...I thought I fixed it...Woops, seems I never actually opened a PR 😊

#553

@vrothberg
Copy link
Member Author

merge me before vendor dance

@edsantiago
Copy link
Member

[please do not gate on me. I do not have the background knowledge to review this]

@rhatdan
Copy link
Member

rhatdan commented May 17, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants