Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--all-platforms: make order deterministic #4527

Closed
wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

A combination of yet-to-be-resolved containers/common/issues/1295 and a non-deterministic processing of the platforms on the Buildah side caused heavy flakes, so make it deterministic.

[NO NEW TESTS NEEDED] - the expected absence of the flake will tell.

Fixes: #4520
Signed-off-by: Valentin Rothberg [email protected]

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

A combination of yet-to-be-resolved containers/common/issues/1295 and a
non-deterministic processing of the platforms on the Buildah side caused
heavy flakes, so make it deterministic.

[NO NEW TESTS NEEDED] - the expected absence of the flake will tell.

Fixes: containers#4520
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

@nalind @edsantiago PTAL

@nalind
Copy link
Member

nalind commented Jan 18, 2023

It's not the nondeterminism that's the bug here. While forcing the iteration order to match that of the base image's manifest list will have that effect with jobs == 1, I don't think it can guarantee stable ordering when jobs > 1.
The manifest list that lets us see the problem also lists its linux/arm/v6 image immediately before its linux/arm/v7 image, so I think for the jobs == 1 case that the test runs, it'll just start erroring out every time.

@vrothberg vrothberg closed this Jan 18, 2023
@vrothberg vrothberg deleted the fix-4520 branch January 18, 2023 14:07
vrothberg added a commit to vrothberg/common that referenced this pull request Jan 18, 2023
This reverts commit ba3a9c0 as it
caused a nasty flake on Buildah [1]

[1] containers/buildah#4527

Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants