Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake: bud-multiple-platform-with-base-as-default-arg: duplicate 'arm' #4520

Closed
edsantiago opened this issue Jan 16, 2023 · 4 comments · Fixed by #4528
Closed

Flake: bud-multiple-platform-with-base-as-default-arg: duplicate 'arm' #4520

edsantiago opened this issue Jan 16, 2023 · 4 comments · Fixed by #4528
Assignees
@flouthoc
Labels
flakes locked - please file new issue/PR

Comments

@edsantiago
Copy link
Member

New flake blowing up in podman-land today:

[+1439s] not ok 322 bud-multiple-platform-with-base-as-default-arg
...
# buildah manifest inspect localhost/testlist
#/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
#|     FAIL: arch list in manifest
#| expected: = '386 amd64 arm arm arm64 ppc64le s390x'
#|   actual:   '386 amd64 arm arm64 ppc64le s390x'
#\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Culprit seems to be the duplicate "arm" here:

buildah/tests/bud.bats

Line 5314 in 9d987b9

assert "$manifests" = "386 amd64 arm arm arm64 ppc64le s390x" "arch list in manifest"

No idea why it's a flake: it seems like the sort of thing that should always fail.

[bud] bud-multiple-platform-with-base-as-default-arg

  • fedora-37 : bud podman fedora-37 root host
  • fedora-37 : bud remote fedora-37 root host [remote]
@edsantiago edsantiago mentioned this issue Jan 16, 2023
Closed
edsantiago added a commit to edsantiago/buildah that referenced this issue Jan 16, 2023
@edsantiago
bud-...-base-as-default : fix dup-arm flake
86c298a 
Some sort of weird error with duplicate "arm" string in
manifest output. Started blowing up in podman CI today.

Fixes: containers#4520

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

Submitted #4521 as possible fix. I'll leave it to others to understand what actually went wrong; all I care about is eliminating flakes.

edsantiago added a commit to edsantiago/buildah that referenced this issue Jan 17, 2023
@edsantiago
bud-...-base-as-default : fix dup-arm flake
836f021 
Some sort of weird error with duplicate "arm" string in
manifest output. Started blowing up in podman CI today.

Fixes: containers#4520

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

Per discussion on IRC: the two arms are intentional. Something about v6 and v7.

@vrothberg
Copy link
Member

@nalind is this the flake you were referring to in libimage? It is suuuuuper flaky in Podman at the moment.

@nalind
Copy link
Member

nalind commented Jan 18, 2023

Yes, I believe that this is also containers/common#1295 (comment).

vrothberg added a commit to vrothberg/buildah that referenced this issue Jan 18, 2023
@vrothberg
--all-platforms: make order deterministic
b34c974 
A combination of yet-to-be-resolved containers/common/issues/1295 and a
non-deterministic processing of the platforms on the Buildah side caused
heavy flakes, so make it deterministic.

[NO NEW TESTS NEEDED] - the expected absence of the flake will tell.

Fixes: containers#4520
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Jan 18, 2023
Closed
vrothberg added a commit to vrothberg/buildah that referenced this issue Jan 18, 2023
@vrothberg
--all-platforms: make order deterministic
a7bb771 
A combination of yet-to-be-resolved containers/common/issues/1295 and a
non-deterministic processing of the platforms on the Buildah side caused
heavy flakes, so make it deterministic.

[NO NEW TESTS NEEDED] - the expected absence of the flake will tell.

Fixes: containers#4520
Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg added a commit to vrothberg/buildah that referenced this issue Jan 18, 2023
@vrothberg
fix bud-multiple-platform-with-base-as-default-arg flake
15bdd2a 
By vendoring c/common (see containers/common/pull/1299).

Fixes: containers#4520
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Jan 18, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flouthoc flouthoc

Labels
flakes locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
4 participants
@edsantiago @nalind @flouthoc @vrothberg