Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] bump dependencies #4155

Merged
merged 7 commits into from
Aug 2, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Aug 1, 2022

Bump to the current versions of containers/storage, containers/image, containers/common, and dependencies that they pull in.
Also cherry-pick #4099, #4071, and the libseccomp.ActKill -> libseccomp.ActKillThread change from #4048 to make linters happy.
And add #4156 because tests break on my workstation without it.
Add the part of #4104 that updates a test to expect an error message that was changed in containers/storage.

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2022

/lgtm
/approve
/hold

nalind and others added 7 commits August 1, 2022 17:18
Bump to the current versions of containers/storage, containers/image,
containers/common, and dependencies that they pull in.

Signed-off-by: Nalin Dahyabhai <[email protected]>
honor the default errno ret value specified for the seccomp profile.

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <[email protected]>
Replace libseccomp.ActKill use with libseccomp.ActKillThread, as the
first is going to be deprecated.

Signed-off-by: Sergio Lopez <[email protected]>
Make linter happy by dropping check which is always true.

Signed-off-by: Aditya R <[email protected]>
The recent update to the storage library switched its error wrapping
from using github.com/pkg/errors to the standard library's fmt.Errorf()
%w specifier, which errors.Cause() can't unwrap.  Use errors.Is() to
check for specific errors from the storage library.

Signed-off-by: Nalin Dahyabhai <[email protected]>
When passing the value ? to a shell function as an argument, don't
forget to quote it, so that it doesn't get expanded as a filename
pattern by the shell.

Signed-off-by: Nalin Dahyabhai <[email protected]>
The recent update to containers/storage removed the word "error" from
the beginning of the "error initializing ID mappings: " error message,
so we shouldn't be expecting it any more.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [flouthoc,nalind,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc
Copy link
Collaborator

flouthoc commented Aug 2, 2022

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit cd18c81 into containers:release-1.26 Aug 2, 2022
@nalind nalind deleted the bump-1.26 branch August 2, 2022 13:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants