Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/(common, storage, image) and Codespell #4104

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 11, 2022

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

I think this also requires containers/common#1077

@flouthoc
Copy link
Collaborator

flouthoc commented Jul 12, 2022

I am not at all sure yet but looks like something broke at c/storage, i am not able to get basic tests passing on local with v1.41.1-0.20220711135711-e0b3b886e994 of c/storage

Edit: I could be wrong cause i was only testing on local.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan force-pushed the main branch 2 times, most recently from 90aedf8 to 58f8b64 Compare July 12, 2022 23:45
@flouthoc
Copy link
Collaborator

This needes revendor of storage and common.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2022
@openshift-ci openshift-ci bot merged commit 8d09f88 into containers:main Jul 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants