Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Update VM images w/ updated bats #4074

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 23, 2022

What type of PR is this?

/kind other

What this PR does / why we need it:

Simply updated images with newer versions of bats and disabling of F35 tests (missing golang 1.18)

Ref: containers/automation_images#140
and
containers/automation_images#149
and
containers/automation_images#146

How to verify it

CI will pass

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich cevich changed the title Cirrus: Update VM images w/ updated bats [WIP] Cirrus: Update VM images w/ updated bats Jun 23, 2022
@cevich cevich requested a review from edsantiago June 23, 2022 21:12
@edsantiago
Copy link
Member

LGTM

@cevich
Copy link
Member Author

cevich commented Jun 24, 2022

Re-run failed tasks, looked like a CDN failure on one, assuming the same for others.

@cevich
Copy link
Member Author

cevich commented Jul 15, 2022

Force-push: Rebased + stuck in new images (built yesterday).

@cevich cevich force-pushed the new_bats branch 2 times, most recently from eac08bb to da9378c Compare July 20, 2022 19:55
@rhatdan
Copy link
Member

rhatdan commented Jul 21, 2022

@cevich is this still a draft?

@rhatdan
Copy link
Member

rhatdan commented Jul 21, 2022

LGTM

@cevich
Copy link
Member Author

cevich commented Jul 21, 2022

Ohh it passed! Yay.

@cevich cevich marked this pull request as ready for review July 21, 2022 13:48
@cevich cevich changed the title [WIP] Cirrus: Update VM images w/ updated bats Cirrus: Update VM images w/ updated bats Jul 21, 2022
@cevich
Copy link
Member Author

cevich commented Jul 21, 2022

Force-push: Rebased.

@cevich
Copy link
Member Author

cevich commented Jul 22, 2022

This is ready to go.

@rhatdan
Copy link
Member

rhatdan commented Jul 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 23, 2022
@rhatdan rhatdan merged commit 0dd9b06 into containers:main Jul 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants